Skip to content

Commit

Permalink
Initial CRUD API for workspaces (#620)
Browse files Browse the repository at this point in the history
This adds a simple and unimplemented REST API for workspaces. Workspaces
will be the base for all other resources in terms of REST resource
mapping, so these go first.

These are initially left entirely unimplemented as
#600 needs to merge

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
  • Loading branch information
JAORMX authored Jan 17, 2025
1 parent dceeef8 commit 7e4b963
Show file tree
Hide file tree
Showing 7 changed files with 137 additions and 9 deletions.
Empty file added src/codegate/api/__init__.py
Empty file.
69 changes: 69 additions & 0 deletions src/codegate/api/v1.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
from fastapi import APIRouter, Response
from fastapi.exceptions import HTTPException
from fastapi.routing import APIRoute

from codegate.api import v1_models
from codegate.pipeline.workspace import commands as wscmd

v1 = APIRouter()
wscrud = wscmd.WorkspaceCrud()


def uniq_name(route: APIRoute):
return f"v1_{route.name}"


@v1.get("/workspaces", tags=["Workspaces"], generate_unique_id_function=uniq_name)
async def list_workspaces() -> v1_models.ListWorkspacesResponse:
"""List all workspaces."""
wslist = await wscrud.get_workspaces()

resp = v1_models.ListWorkspacesResponse.from_db_workspaces(wslist)

return resp


@v1.get("/workspaces/active", tags=["Workspaces"], generate_unique_id_function=uniq_name)
async def list_active_workspaces() -> v1_models.ListActiveWorkspacesResponse:
"""List all active workspaces.
In it's current form, this function will only return one workspace. That is,
the globally active workspace."""
activews = await wscrud.get_active_workspace()

resp = v1_models.ListActiveWorkspacesResponse.from_db_workspaces(activews)

return resp


@v1.post("/workspaces/active", tags=["Workspaces"], generate_unique_id_function=uniq_name)
async def activate_workspace(request: v1_models.ActivateWorkspaceRequest, status_code=204):
"""Activate a workspace by name."""
activated = await wscrud.activate_workspace(request.name)

# TODO: Refactor
if not activated:
return HTTPException(status_code=409, detail="Workspace already active")

return Response(status_code=204)


@v1.post("/workspaces", tags=["Workspaces"], generate_unique_id_function=uniq_name, status_code=201)
async def create_workspace(request: v1_models.CreateWorkspaceRequest):
"""Create a new workspace."""
# Input validation is done in the model
created = await wscrud.add_workspace(request.name)

# TODO: refactor to use a more specific exception
if not created:
raise HTTPException(status_code=400, detail="Failed to create workspace")

return v1_models.Workspace(name=request.name)



@v1.delete("/workspaces/{workspace_name}", tags=["Workspaces"],
generate_unique_id_function=uniq_name, status_code=204)
async def delete_workspace(workspace_name: str):
"""Delete a workspace by name."""
raise NotImplementedError
44 changes: 44 additions & 0 deletions src/codegate/api/v1_models.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
from typing import Any, List, Optional

import pydantic

from codegate.db import models as db_models


class Workspace(pydantic.BaseModel):
name: str
is_active: bool

class ActiveWorkspace(Workspace):
# TODO: use a more specific type for last_updated
last_updated: Any

class ListWorkspacesResponse(pydantic.BaseModel):
workspaces: list[Workspace]

@classmethod
def from_db_workspaces(
cls, db_workspaces: List[db_models.WorkspaceActive])-> "ListWorkspacesResponse":
return cls(workspaces=[
Workspace(name=ws.name, is_active=ws.active_workspace_id is not None)
for ws in db_workspaces])

class ListActiveWorkspacesResponse(pydantic.BaseModel):
workspaces: list[ActiveWorkspace]

@classmethod
def from_db_workspaces(
cls, ws: Optional[db_models.ActiveWorkspace]) -> "ListActiveWorkspacesResponse":
if ws is None:
return cls(workspaces=[])
return cls(workspaces=[
ActiveWorkspace(name=ws.name,
is_active=True,
last_updated=ws.last_update)
])

class CreateWorkspaceRequest(pydantic.BaseModel):
name: str

class ActivateWorkspaceRequest(pydantic.BaseModel):
name: str
9 changes: 7 additions & 2 deletions src/codegate/db/connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
alert_queue = asyncio.Queue()
fim_cache = FimCache()


class DbCodeGate:
_instance = None

Expand Down Expand Up @@ -256,7 +255,13 @@ async def add_workspace(self, workspace_name: str) -> Optional[Workspace]:
RETURNING *
"""
)
added_workspace = await self._execute_update_pydantic_model(workspace, sql)
try:
added_workspace = await self._execute_update_pydantic_model(
workspace, sql)
except Exception as e:
logger.error(f"Failed to add workspace: {workspace_name}.", error=str(e))
return None

return added_workspace

async def update_session(self, session: Session) -> Optional[Session]:
Expand Down
15 changes: 11 additions & 4 deletions src/codegate/pipeline/workspace/commands.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import datetime
from typing import Optional, Tuple
from typing import List, Optional, Tuple

from codegate.db.connection import DbReader, DbRecorder
from codegate.db.models import Session, Workspace
from codegate.db.models import ActiveWorkspace, Session, Workspace, WorkspaceActive


class WorkspaceCrud:
Expand All @@ -18,15 +18,22 @@ async def add_workspace(self, new_workspace_name: str) -> bool:
name (str): The name of the workspace
"""
db_recorder = DbRecorder()
workspace_created = await db_recorder.add_workspace(new_workspace_name)
workspace_created = await db_recorder.add_workspace(
new_workspace_name)
return bool(workspace_created)

async def get_workspaces(self):
async def get_workspaces(self) -> List[WorkspaceActive]:
"""
Get all workspaces
"""
return await self._db_reader.get_workspaces()

async def get_active_workspace(self) -> Optional[ActiveWorkspace]:
"""
Get the active workspace
"""
return await self._db_reader.get_active_workspace()

async def _is_workspace_active_or_not_exist(
self, workspace_name: str
) -> Tuple[bool, Optional[Session], Optional[Workspace]]:
Expand Down
4 changes: 4 additions & 0 deletions src/codegate/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from starlette.middleware.errors import ServerErrorMiddleware

from codegate import __description__, __version__
from codegate.api.v1 import v1
from codegate.dashboard.dashboard import dashboard_router
from codegate.pipeline.factory import PipelineFactory
from codegate.providers.anthropic.provider import AnthropicProvider
Expand Down Expand Up @@ -97,4 +98,7 @@ async def health_check():
app.include_router(system_router)
app.include_router(dashboard_router)

# CodeGate API
app.include_router(v1, prefix="/api/v1", tags=["CodeGate API"])

return app
5 changes: 2 additions & 3 deletions tests/pipeline/workspace/test_workspace.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import datetime
from unittest.mock import AsyncMock, patch

import pytest

from codegate.db.models import Session, Workspace, WorkspaceActive
from codegate.pipeline.workspace.commands import WorkspaceCommands, WorkspaceCrud
from codegate.db.models import WorkspaceActive
from codegate.pipeline.workspace.commands import WorkspaceCommands


@pytest.mark.asyncio
Expand Down

0 comments on commit 7e4b963

Please sign in to comment.