feat: initial work on codegate version check widget #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12828464111Details
💛 - Coveralls |
peppescg
reviewed
Jan 16, 2025
Comment on lines
+9
to
+12
| const resp = await fetch( | ||
| new URL("/health", import.meta.env.VITE_BASE_API_URL), | ||
| ); | ||
| const data = (await resp.json()) as unknown as HealthResponse; |
There was a problem hiding this comment.
this api is not integrated into the openapi in codegate?
There was a problem hiding this comment.
The health one isn't AFAIK — but the version one should be, that's a good point — once the BE work is in, we can generate it & use the API client.
I also noticed a bug in the previous PR where the client wouldn't be initialised with a base URL on first mount and we would make a request to a relative path of the frontend application — should investigate why that is as well.
There was a problem hiding this comment.
There's some discussion happening on best way to handle OpenAPI spec in discord — will come back and clean this up once that's settled.
peppescg
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a second check to the "CodeGate Status" widget — depends on stacklok/codegate#612
Related to stacklok/codegate#555
Screen.Recording.2025-01-16.at.1.30.54.PM.mov