Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show README for prompts when available #313

Merged
merged 3 commits into from
Feb 14, 2025
Merged

feat: show README for prompts when available #313

merged 3 commits into from
Feb 14, 2025

Conversation

kantord
Copy link
Member

@kantord kantord commented Feb 13, 2025

this actually fixes: #270

TLDR; many of the prompts are committed by a different person, not the author. In such cases, the author is usually credited in the README, but with no link, to their github account or no mention of the github username.

So in such cases, to avoid misattributing the prompt we can show a link to the readme instead. This can also be understood as a feature, to get help with the prompt

Screenshot_select-area_20250213165946

I also added a script (& readme for it) to update the JSON, and I also created this repo: to store the prompts and the python script that creates the JSON in the first place. This way, adding new prompts is still a manual process, but a quite simple one.

https://github.com/stacklok/prompt-library

@kantord kantord changed the title chore: update built-in prompt database feat: show README for prompts when available Feb 13, 2025
@kantord kantord marked this pull request as ready for review February 13, 2025 16:43
@kantord kantord enabled auto-merge (squash) February 13, 2025 16:55
@coveralls
Copy link
Collaborator

coveralls commented Feb 13, 2025

Pull Request Test Coverage Report for Build 13328504962

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 68.584%

Totals Coverage Status
Change from base Build 13328355270: 0.02%
Covered Lines: 769
Relevant Lines: 1061

💛 - Coveralls

alex-mcgovern
alex-mcgovern previously approved these changes Feb 14, 2025
@kantord kantord merged commit a388e49 into main Feb 14, 2025
7 checks passed
@kantord kantord deleted the rules-db-fixes branch February 14, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect author attribution in preset prompts library
3 participants