Skip to content

Commit

Permalink
fix: cannot delete endpoint URL (#318)
Browse files Browse the repository at this point in the history
fixes: #284
  • Loading branch information
kantord authored Feb 14, 2025
1 parent 38f2ecc commit 18ac940
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 10 deletions.
4 changes: 0 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 1 addition & 3 deletions src/features/providers/components/provider-form.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ interface Props {
export function ProviderForm({ provider, setProvider }: Props) {
const providerAuthType =
provider.auth_type || getProviderAuthByType(provider.provider_type)
const providerEndpoint =
provider.endpoint || getProviderEndpointByAuthType(provider.provider_type)

const handleProviderType = (provider: AddProviderEndpointRequest) => {
setProvider({
Expand Down Expand Up @@ -87,7 +85,7 @@ export function ProviderForm({ provider, setProvider }: Props) {
onChange={(endpoint) => setProvider({ ...provider, endpoint })}
>
<Label>Endpoint</Label>
<Input placeholder="Provider endpoint" value={providerEndpoint} />
<Input placeholder="Provider endpoint" value={provider.endpoint} />
</TextField>
</div>
<div className="py-3">
Expand Down
11 changes: 8 additions & 3 deletions src/routes/route-provider-create.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { ProviderDialog } from '@/features/providers/components/provider-dialog'
import { ProviderDialogFooter } from '@/features/providers/components/provider-dialog-footer'
import { ProviderForm } from '@/features/providers/components/provider-form'
import { useMutationCreateProvider } from '@/features/providers/hooks/use-mutation-create-provider'
import { getProviderEndpointByAuthType } from '@/features/providers/lib/utils'
import { DialogContent, Form } from '@stacklok/ui-kit'
import { useState } from 'react'

Expand All @@ -20,9 +21,13 @@ const DEFAULT_PROVIDER_STATE = {
}

export function RouteProviderCreate() {
const [provider, setProvider] = useState<AddProviderEndpointRequest>(
DEFAULT_PROVIDER_STATE
)
const [provider, setProvider] = useState<AddProviderEndpointRequest>({
...DEFAULT_PROVIDER_STATE,
endpoint: getProviderEndpointByAuthType(
DEFAULT_PROVIDER_STATE.provider_type
),
})

const { mutateAsync } = useMutationCreateProvider()

const handleSubmit = (event: React.FormEvent) => {
Expand Down

0 comments on commit 18ac940

Please sign in to comment.