Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize python code base, part 2 #2418

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Conversation

nim65s
Copy link
Contributor

@nim65s nim65s commented Sep 16, 2024

Hi,

This follow #2367 by enabling additional opt-in features of ruff, and implementing those either manually or through auto-fix.

Commit history was rewritten to ease review, but things can be squashed once agreed.

@hrp2-14

This comment was marked as resolved.

@nim65s nim65s changed the base branch from master to devel September 16, 2024 11:03
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:

  • build_collision (build Pinocchio with coal support)
  • build_casadi (build Pinocchio with CasADi support)
  • build_autodiff (build Pinocchio with CppAD support)
  • build_codegen (build Pinocchio with CppADCodeGen support)
  • build_extra (build Pinocchio with extra algorithms)
  • build_mpfr (build Pinocchio with Boost.Multiprecision support)
  • build_sdf (build Pinocchio with SDF parser)
  • build_accelerate (build Pinocchio with APPLE Accelerate framework support)
  • build_all (build Pinocchio with ALL the options stated above)

Thanks.
The Pinocchio development team.

@ManifoldFR
Copy link
Member

Great work again @nim65s :)

Copy link
Contributor

@jcarpent jcarpent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nim65s for the cleanage of the code.
Could you squeeze everything into a single commit?

@nim65s
Copy link
Contributor Author

nim65s commented Sep 16, 2024

done

@nim65s
Copy link
Contributor Author

nim65s commented Sep 20, 2024

macos CI is consistently failing with:

CMake Error at CMakeLists.txt:324 (message):
  Your version of Eigen is too low.  Should be at least 3.4.90.  Current
  version is 3.4.0.

windows CI is failing with

C:\Miniconda\envs\pinocchio\Library\include\cppad/cg/cg.hpp(217): error C2143: syntax error: missing ';' before '<'
C:\Miniconda\envs\pinocchio\Library\include\cppad/cg/cg.hpp(217): error C2433: 'CppAD::cg::NearEqual': 'friend' not permitted on data declarations
C:\Miniconda\envs\pinocchio\Library\include\cppad/cg/cg.hpp(217): error C2365: 'CppAD::cg::NearEqual': redefinition; previous definition was 'function'

In both cases, this is not related to this PR.

@jcarpent
Copy link
Contributor

macos CI is consistently failing with:

CMake Error at CMakeLists.txt:324 (message):
  Your version of Eigen is too low.  Should be at least 3.4.90.  Current
  version is 3.4.0.

For this issue, I've removed the support Apple Accelerate for build_all

@jcarpent jcarpent merged commit 500e6a9 into stack-of-tasks:devel Sep 22, 2024
14 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants