Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mlm:artifact_type check missing in assets and other disallowed MLM fields #59

Merged
merged 24 commits into from
Nov 22, 2024

Conversation

fmigneault
Copy link
Collaborator

Description

  • Improve the README regarding allowed/disallowed fields in the Assets vs Item vs both.
  • Align the allowed/disallowed fields behavior with the JSON schema
  • Ensure that, for the Asset that contains the mlm:model role, the mlm:artifact_type is also provided
  • Add multiple tests validating above behaviors

Related Issue

Type of Change

  • 📚 Examples, docs, tutorials or dependencies update;
  • 🔧 Bug fix (non-breaking change which fixes an issue);
  • 🥂 Improvement (non-breaking change which improves an existing feature);
  • 🚀 New feature (non-breaking change which adds functionality);
  • 💥 Breaking change (fix or feature that would cause existing functionality to change);
  • 🔐 Security fix.

Checklist

  • I've read the CONTRIBUTING.md guide;
  • I've updated the code style using make check;
  • I've written tests for all new methods and classes that I created;
  • I've written the docstring in Google format for all the methods and classes that I used.

@fmigneault fmigneault self-assigned this Nov 7, 2024
@fmigneault fmigneault requested a review from rbavery November 7, 2024 00:48
Copy link
Collaborator

@rbavery rbavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great overall, one question on if we should mark a couple of other fields as only Item properties.

json-schema/schema.json Show resolved Hide resolved
@fmigneault fmigneault requested a review from rbavery November 22, 2024 21:05
@fmigneault fmigneault merged commit 42052ec into main Nov 22, 2024
8 checks passed
@fmigneault fmigneault deleted the fix-mlm-artefact-v2 branch November 22, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix missing mlm:artifact_type in JSON schema
2 participants