-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add compile_method flag and add other framework artifact types #40
base: main
Are you sure you want to change the base?
Conversation
README.md
Outdated
| `torch.jit.save` | A [`TorchScript`][pytorch-jit-script] model artifact obtained with one or more of the graph export options Torchscript Tracing and Torchscript Scripting. | | ||
| `torch.export.save` | A model artifact storing an ExportedProgram obtained by [`torch.export.export`][pytorch-export] (i.e.: `.pt2`). | | ||
| `TFSavedModel` | A [SavedModel][tf-save] from Tensorflow or Keras. | | ||
| `Keras_v3` | Keras v3 is the [recommended format][keras-recommended] by the Tensorflow team. See this example to [save and load models][keras-example] and the update to date docs [disambiguating different save methods][keras-methods] in TF and Keras.. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as previous. Any reference function to be employed?
I would assume Keras on its own has a way to generate that file, regardless of how TF can reload it. Maybe: keras.saving.serialize_keras_object
(https://keras.io/api/models/model_saving_apis/serialization_utils/) ?
extra .
to remove at the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed all these to point to specific functions and included an argument in one of them, tf.keras.Model.export(format='tf_saved_model')
that is tensorflow specific. The other two functions always output the same artifact. Would prefer to use the high level function tf.keras.Model.export(format='tf_saved_model')
as the artifact type since it is what users will typically interact with rather than a lower level function like keras.saving.serialize_keras_object
@fmigneault I added mlm:compile_method to the JSON Schema but this seems to have broken validation of
I went through and added
Any tips on what I need to change in the schema? I want it to be allowed under the asset role, if it is present I want it validated to be a string, but unlike |
Description
Related Issue
Type of Change
Checklist
CONTRIBUTING.md
guide;make check
;Google
format for all the methods and classes that I used.