Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor norm-type/statistics mlm:input properties #39

Merged
merged 15 commits into from
Nov 5, 2024
Merged

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Oct 30, 2024

Description

  • Adds the scaling field to replace the combination of norm_type, norm_clip, norm_by_channel and statistics field combinations under a common definition.
  • Adds better validation of expected sub-fields by each scaling type.

Related Issue

Type of Change

  • 📚 Examples, docs, tutorials or dependencies update;
  • 🔧 Bug fix (non-breaking change which fixes an issue);
  • 🥂 Improvement (non-breaking change which improves an existing feature);
  • 🚀 New feature (non-breaking change which adds functionality);
  • 💥 Breaking change (fix or feature that would cause existing functionality to change);
  • 🔐 Security fix.

Checklist

  • I've read the CONTRIBUTING.md guide;
  • I've updated the code style using make check;
  • I've written tests for all new methods and classes that I created;
  • I've written the docstring in Google format for all the methods and classes that I used.

@fmigneault fmigneault self-assigned this Oct 30, 2024
@fmigneault fmigneault changed the title [wip] add check for matching norm-type/statistics mlm:input properties refactor norm-type/statistics mlm:input properties Nov 1, 2024
@fmigneault fmigneault requested a review from rbavery November 1, 2024 04:19
stac_model/input.py Outdated Show resolved Hide resolved
@fmigneault fmigneault requested a review from rbavery November 2, 2024 14:34
json-schema/schema.json Outdated Show resolved Hide resolved
@fmigneault fmigneault requested a review from rbavery November 5, 2024 16:14
Copy link
Collaborator

@rbavery rbavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! looking forward to clearer semantics for applying statistics (no value_scaling) to inputs.

@fmigneault fmigneault merged commit aa8ff29 into main Nov 5, 2024
8 checks passed
@fmigneault fmigneault deleted the norm-type branch November 5, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants