Refactor i18n implementation

[lkeegan]

• main improvements
  • all language texts can now be edited from the admin interface
  • in frontend code we now have autocomplete for translation ids
• change in use
  • i18n-svelte -> lib/i18n.svelte
  • $locale -> i18n.locale
  • $locales -> i18n.locales
  • $_('a.b') -> i18n.tr.a.b
  • to add a text, add the id to lib/translations.ts
• code changes
  • remove i18n-svelte library
  • remove locales/de.json: this is now included in the static folder of the deployed website, not part of the frontend source code anymore
  • use camel case for all translation ids for consistency and to allow use without quotes
  • de is now also editable in admin interface
• resolves Allow admins to edit the german translations #211

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0.14245% with 701 lines in your changes missing coverage. Please review.

Project coverage is 30.30%. Comparing base (8acd15e) to head (7ea1a85).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
frontend/src/lib/translations.ts	0.33%	297 Missing ⚠️
...end/src/lib/components/ChildrenRegistration.svelte	0.00%	40 Missing ⚠️
...rontend/src/lib/components/ChildrenFeedback.svelte	0.00%	35 Missing ⚠️
frontend/src/lib/i18n.svelte.ts	0.00%	28 Missing and 1 partial ⚠️
...ntend/src/lib/components/Admin/Translations.svelte	0.00%	22 Missing ⚠️
...ontend/src/lib/components/MilestoneOverview.svelte	0.00%	21 Missing ⚠️
frontend/src/lib/components/Milestone.svelte	0.00%	20 Missing ⚠️
frontend/src/lib/components/MilestoneGroup.svelte	0.00%	18 Missing ⚠️
...b/components/Admin/SubmittedMilestoneImages.svelte	0.00%	16 Missing ⚠️
frontend/src/lib/components/Frontpage.svelte	0.00%	15 Missing ⚠️
... and 40 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
- Coverage   32.04%   30.30%   -1.74%     
==========================================
  Files         114      115       +1     
  Lines        4179     4421     +242     
  Branches       99      100       +1     
==========================================
+ Hits         1339     1340       +1     
- Misses       2756     2997     +241     
  Partials       84       84              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[MaHaWo]

nice addition, looks good. The only question I have is if there would be a way to have defaults for, e.g., the names of the buttons in the profile popover or similar functional elements. Someone who is not familiar with the code might be a little confused by the amount of names and labels and doesn´t know what to provide there upon initial deployment.

[lkeegan]

nice addition, looks good. The only question I have is if there would be a way to have defaults for, e.g., the names of the buttons in the profile popover or similar functional elements. Someone who is not familiar with the code might be a little confused by the amount of names and labels and doesn´t know what to provide there upon initial deployment.

Yes I was also thinking about that and I agree - I guess the most developer-friendly option would be to put the actual german text in https://github.com/ssciwr/mondey/pull/213/files#diff-63f05097c4a548b2bc2106f45ca89b7986d834aaddc361c23ea8b1850c2e59b6 instead of empty strings, even if this wastes some bandwidth.

The alternative would be to ship a de.json as part of the source code but not part of the website, and modify the local docker / testing setup to serve that at runtime, but don't think it's worth the extra complications just to avoid downloading some redundant data, at least for now.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud