refactor: improve APIApplicationStatusAll usability with generics

squarecloudofc · Dec 4, 2024 · 3bfd7c6 · 3bfd7c6
1 parent faeebaf
commit 3bfd7c6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/.changeset/serious-schools-notice.md b/.changeset/serious-schools-notice.md
@@ -0,0 +1,5 @@
+---
+"@squarecloud/api-types": minor
+---
+
+Fix `APIApplicationStatusAll` to show/hide usage depending on `running` property.
diff --git a/payloads/v2/status.ts b/payloads/v2/status.ts
@@ -40,12 +40,11 @@ export type APIApplicationStatusPayload = APIPayload<APIApplicationStatus>;
 /**
  * @see /apps/status https://docs.squarecloud.app/api-reference/endpoint/apps/status-all
  */
-export interface APIApplicationStatusAll {
+export type APIApplicationStatusAll<Running extends boolean = boolean> = {
 	id: ApplicationId;
-	cpu?: string;
-	ram?: string;
-	running: boolean;
-}
+} & (Running extends true
+	? { running: true; cpu: string; ram: string }
+	: { running: false; cpu?: never; ram?: never });
 
 export type APIApplicationStatusAllPayload = APIPayload<
 	APIApplicationStatusAll[]