Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Bazel dylib issue due to aggressive code stripping #321

Merged
merged 1 commit into from
Feb 19, 2025
+1 −0
Merged

Resolve Bazel dylib issue due to aggressive code stripping #321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions WorkflowUI/Sources/Screen/ScreenViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ open class ScreenViewController<ScreenType: Screen>: WorkflowUIViewController {
ScreenType.self
}

@_alwaysEmitIntoClient
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be great to add some context around this so that future-us will know what the heck this was added for.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also... is this a workaround for a linker issue? can we deal with it via build args/configuration vs changing the source? is this a bug that should be reported somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a workaround for a linker issue?

This is a linker issue; however, it works fine in SPM land. There's something about the Square Bazel build infrastructure (and the current versions we're pinned at) which results in this.

can we deal with it via build args/configuration vs changing the source?

@congt tried a ton of things, and this was the only thing we could do to solve it previously

is this a bug that should be reported somewhere?

Hard to say since it's Bazel specific and possibly Square's rules specific

private var previousEnvironment: ViewEnvironment

public required init(screen: ScreenType, environment: ViewEnvironment) {
Expand Down
Loading