Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Burst for parameterized tests #1534

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Adopt Burst for parameterized tests #1534

merged 1 commit into from
Oct 17, 2024

Conversation

swankjesse
Copy link
Collaborator

It supports Kotlin/Multiplatform.

https://github.com/cashapp/burst

@swankjesse
Copy link
Collaborator Author

Looks good.
Screenshot 2024-10-16 at 9 35 02 AM

Copy link
Collaborator

@JakeWharton JakeWharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just need to target the annotation to Java 8 and should be good.

enum class Factory {
BUFFER {
override fun create(data: Buffer) = data
override fun toString() = "Buffer"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can rename all these in a follow-up to have these nicer names like you did for the new one at the bottom. No need for screaming case anymore.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On it!

@swankjesse
Copy link
Collaborator Author

Hmmm, unexpected build failure:

> Task :okio:compileCommonMainKotlinMetadata FAILED
e: file:///Volumes/Development/okio/okio/src/commonMain/kotlin/okio/Buffer.kt:31:8 Class 'Buffer' is not abstract and does not implement abstract member 'timeout'.
e: file:///Volumes/Development/okio/okio/src/commonMain/kotlin/okio/HashingSink.kt:35:8 Class 'HashingSink' is not abstract and does not implement abstract member 'write'.
e: file:///Volumes/Development/okio/okio/src/commonMain/kotlin/okio/HashingSource.kt:36:8 Class 'HashingSource' is not abstract and does not implement abstract member 'read'.
e: file:///Volumes/Development/okio/okio/src/commonMain/kotlin/okio/RealBufferedSink.kt:19:17 Class 'RealBufferedSink' is not abstract and does not implement abstract member 'buffer'.
e: file:///Volumes/Development/okio/okio/src/commonMain/kotlin/okio/RealBufferedSource.kt:19:17 Class 'RealBufferedSource' is not abstract and does not implement abstract member 'buffer'.

@JakeWharton
Copy link
Collaborator

You have to go through the Kotlin 2 migration. K2 forces expect types to redeclare members inherited from interfaces, which is what looks like that error is indicating.

@swankjesse
Copy link
Collaborator Author

Ooooh Kotlin 2. Checks out.
#1535

@swankjesse swankjesse enabled auto-merge (squash) October 17, 2024 17:51
@swankjesse swankjesse disabled auto-merge October 17, 2024 19:08
@swankjesse swankjesse merged commit 6bcd3cf into master Oct 17, 2024
11 checks passed
@swankjesse swankjesse deleted the jwilson.1016.burst branch October 17, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants