-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt Burst for parameterized tests #1534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Just need to target the annotation to Java 8 and should be good.
enum class Factory { | ||
BUFFER { | ||
override fun create(data: Buffer) = data | ||
override fun toString() = "Buffer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can rename all these in a follow-up to have these nicer names like you did for the new one at the bottom. No need for screaming case anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On it!
0d4b0e4
to
ff9797c
Compare
Hmmm, unexpected build failure:
|
You have to go through the Kotlin 2 migration. K2 forces expect types to redeclare members inherited from interfaces, which is what looks like that error is indicating. |
Ooooh Kotlin 2. Checks out. |
It supports Kotlin/Multiplatform. https://github.com/cashapp/burst
ff9797c
to
6c4e379
Compare
It supports Kotlin/Multiplatform.
https://github.com/cashapp/burst