Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert some tests to Kotlin #8152

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Convert some tests to Kotlin #8152

merged 2 commits into from
Dec 21, 2023

Conversation

swankjesse
Copy link
Collaborator

No description provided.

@swankjesse
Copy link
Collaborator Author

I split it into two commits to make it easier to compare the effects of converting to Kotlin.
d148956?diff=split&w=1

I’d like to replace all uses of try/fail with assertFailure throughout OkHttp’s tests. But a prerequisite to that is converting tests that use the old pattern to Kotlin!

yschimke
yschimke approved these changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@yschimke yschimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hoping that was mainly mechanical. I skimmed and patterned match by eye the dark green sections of the diffs. But could have missed something you edited :)

@swankjesse swankjesse merged commit 1561bba into master Dec 21, 2023
19 checks passed
@swankjesse swankjesse deleted the jwilson.1220.kt_tests branch December 21, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yschimke yschimke yschimke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swankjesse @yschimke @squarejesse