fix: spec update (PR #7) - blocklist filtering in uppercase-only alph…

…abet

CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG
 
+**v0.1.2:**
+- Bug fix: spec update (PR #7): blocklist filtering in uppercase-only alphabet [[PR #7](https://github.com/sqids/sqids-spec/pull/7)]
+- Lower uniques test from 1_000_000 to 10_000
+
 **v0.1.1:**
 - Lowering Ruby version requirement to 3.0
 

lib/sqids.rb

@@ -28,7 +28,7 @@ def initialize(options = {})
     end
 
     filtered_blocklist = blocklist.select do |word|
-      word.length >= 3 && (word.chars - alphabet.chars).empty?
+      word.length >= 3 && (word.downcase.chars - alphabet.downcase.chars).empty?
     end.to_set(&:downcase)
 
     @alphabet = shuffle(alphabet)

spec/blocklist_spec.rb

@@ -52,4 +52,15 @@
 
     expect(sqids.decode(sqids.encode([1_000]))).to eq([1_000])
   end
+
+  it 'blocklist filtering in constructor' do
+    # lowercase blocklist in only-uppercase alphabet
+    sqids = Sqids.new(alphabet: 'ABCDEFGHIJKLMNOPQRSTUVWXYZ', blocklist: Set.new(['sqnmpn']))
+
+    id = sqids.encode([1, 2, 3])
+    numbers = sqids.decode(id)
+
+    expect(id).to eq('ULPBZGBM') # without blocklist, would've been "SQNMPN"
+    expect(numbers).to eq([1, 2, 3])
+  end
 end

spec/uniques_spec.rb

@@ -3,7 +3,7 @@
 require 'rspec'
 require_relative '../lib/sqids'
 
-upper = 1_000_000
+upper = 10_000
 
 describe Sqids do
   let(:sqids) { Sqids.new(min_length: Sqids::DEFAULT_ALPHABET.length) }

sqids.gemspec

@@ -7,7 +7,7 @@ require 'sqids'
 
 Gem::Specification.new do |gem|
   gem.name          = 'sqids'
-  gem.version       = '0.1.1'
+  gem.version       = '0.1.2'
   gem.authors       = ['Sqids Maintainers']
   gem.summary       = 'Generate YouTube-like ids from numbers.'
   gem.homepage      = 'https://sqids.org/ruby'