Updated job urls to show names instead of id # #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spryker-community ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fsmeier
reviewed
Oct 25, 2024
| @@ -31,9 +31,26 @@ function hasSprykerCertifications(certifications: SprykerCertifications): boolea | |||
| return certifications.backEndDeveloper || certifications.solutionArchitect; | |||
| } | |||
|
|
|||
| // Generate URL-friendly slug from first and last name | |||
| function generateNameSlug(firstName: string, lastName: string): string { | |||
There was a problem hiding this comment.
for next time a small suggestion: generateSlugByFirstnameLastname()
the current name does not really tell what it is about; good function/method names are better than comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For better SEO, I updated the URL/slug to use the persons name instead of their database ID