Skip to content

Commit

Permalink
Update Prometheus metrics prop names (Boot 3.x)
Browse files Browse the repository at this point in the history
  • Loading branch information
onobc committed Aug 12, 2024
1 parent b61c3c9 commit be08425
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/carvel/test/servers.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -485,14 +485,14 @@ describe('servers', () => {

const dataflowDoc = parseYamlDocument(dataflowApplicationYaml);
const dataflowJson = dataflowDoc.toJSON();
const enabled1 = lodash.get(dataflowJson, 'management.metrics.export.prometheus.enabled') as boolean;
const enabled1 = lodash.get(dataflowJson, 'management.prometheus.metrics.export.enabled') as boolean;
expect(enabled1).toBeTrue();
const url = lodash.get(dataflowJson, 'spring.cloud.dataflow.metrics.dashboard.url') as string;
expect(url).toBeFalsy();

const skipperDoc = parseYamlDocument(skipperApplicationYaml);
const skipperJson = skipperDoc.toJSON();
const enabled2 = lodash.get(skipperJson, 'management.metrics.export.prometheus.enabled') as boolean;
const enabled2 = lodash.get(skipperJson, 'management.prometheus.metrics.export.enabled') as boolean;
expect(enabled2).toBeTrue();
});

Expand Down
8 changes: 4 additions & 4 deletions src/deploy/carvel/configure-prometheus-proxy.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@
function set_properties() {
PREFIX=$1
yq "${PREFIX}.micrometer.prometheus.rsocket.host=\"$HOST\"" -i ./scdf-values.yml
yq "${PREFIX}.management.metrics.export.prometheus.pushgateway.base-url=\"http://$HOST:$PORT\"" -i ./scdf-values.yml
yq "${PREFIX}.management.metrics.export.prometheus.pushgateway.enabled=true" -i ./scdf-values.yml
yq "${PREFIX}.management.metrics.export.prometheus.pushgateway.shutdown-operation=\"PUSH\"" -i ./scdf-values.yml
yq "${PREFIX}.management.metrics.export.prometheus.step=\"$STEP\"" -i ./scdf-values.yml
yq "${PREFIX}.management.prometheus.metrics.export.pushgateway.base-url=\"http://$HOST:$PORT\"" -i ./scdf-values.yml
yq "${PREFIX}.management.prometheus.metrics.export.pushgateway.enabled=true" -i ./scdf-values.yml
yq "${PREFIX}.management.prometheus.metrics.export.pushgateway.shutdown-operation=\"PUSH\"" -i ./scdf-values.yml
yq "${PREFIX}.management.prometheus.metrics.export.step=\"$STEP\"" -i ./scdf-values.yml
}
if [ "$2" = "" ]; then
echo "Usage is: <host> <port> [step]"
Expand Down

0 comments on commit be08425

Please sign in to comment.