Skip to content

Commit

Permalink
Remove Deprecated Constructor from DefaultTaskExecutionInfoService
Browse files Browse the repository at this point in the history
resolves #6020

Signed-off-by: Glenn Renfro <grenfro@vmware.com>

Add note to whats-new doc about constructor removal

Signed-off-by: Glenn Renfro <grenfro@vmware.com>
  • Loading branch information
cppwfs committed Nov 6, 2024
1 parent ea8e5a3 commit 4868bbb
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 33 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -92,38 +92,6 @@ public class DefaultTaskExecutionInfoService implements TaskExecutionInfoService

private final ComposedTaskRunnerConfigurationProperties composedTaskRunnerConfigurationProperties;

/**
* Initializes the {@link DefaultTaskExecutionInfoService}.
*
* @param dataSourceProperties the data source properties.
* @param appRegistryService URI registry this service will use to look up app URIs.
* @param taskExplorer the explorer this service will use to lookup task executions
* @param taskDefinitionRepository the {@link TaskDefinitionRepository} this service will
* use for task CRUD operations.
* @param taskConfigurationProperties the properties used to define the behavior of tasks
* @param launcherRepository the launcher repository
* @param taskPlatforms the task platforms
*/
@Deprecated
public DefaultTaskExecutionInfoService(
DataSourceProperties dataSourceProperties,
AppRegistryService appRegistryService,
DataflowTaskExplorer taskExplorer,
TaskDefinitionRepository taskDefinitionRepository,
TaskConfigurationProperties taskConfigurationProperties,
LauncherRepository launcherRepository,
List<TaskPlatform> taskPlatforms
) {
this(dataSourceProperties,
appRegistryService,
taskExplorer,
taskDefinitionRepository,
taskConfigurationProperties,
launcherRepository,
taskPlatforms,
null);
}

/**
* Initializes the {@link DefaultTaskExecutionInfoService}.
*
Expand Down
2 changes: 1 addition & 1 deletion whats-new.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ VersionInfoProperties versionInfoProperties, SecurityStateBean securityStateBean
* `DockerComposeRule.waitingForService(String serviceName, HealthCheck<Container> healthCheck)` has been replaced by `DockerComposeRule.waitingForService(String serviceName, HealthCheck<Container> healthCheck, ReadableDuration timeout)`.
* The deprecated `rollback(String releaseName, int releaseVersion)` method in SkipperClient has been removed. Use `rollback(RollbackRequest rollbackRequest).
* Removed the `DefaultTaskExecutionService` constructor that does not take the `composedTaskRunnerConfigurationProperties` parameter. Use the constructor that offers the `composedTaskRunnerConfigurationProperties` parameter.

* * Removed the `DefaultTaskExecutionInfoService` constructor that does not take the `composedTaskRunnerConfigurationProperties` parameter. Use the constructor that offers the `composedTaskRunnerConfigurationProperties` parameter.
=== Breaking Changes
Announce deprecated changes here

0 comments on commit 4868bbb

Please sign in to comment.