Improve search performance #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rder if no ide filter is present
…ming search if those can not reach the result list: if the sorting criteria has a lookup and we are able to iterate the possible streams in the order described by that lookup, we can abort the search as soon as the result list is full
|
What kind of queries are faster with this? Tracking execution time of some queries in ci would be nice to see regressions over time |
|
The empty query was my primary test case |
- adds support for or-connected queries - disables using the sort lookup if not useful (no limit) - perform some searches in file order to make loading more efficient if no early exit is possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset improves the performance of compatible searches heavily (from a couple of seconds to ~300ms in my current testset)
Searches using or'ed conditions are currently not compatible but it would not be too difficult to support that.