:handle tags with whitespace correctly

spq · Dec 3, 2024 · b6b23c5 · b6b23c5
1 parent 4e3fb4d
commit b6b23c5
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/web/src/components/Navigation.vue b/web/src/components/Navigation.vue
@@ -462,23 +462,30 @@ async function appendOrRemoveFilter(e: Event) {
     return;
   }
 
+  function formatValue(value: string) {
+    return /\s/g.test(value.trim()) ? `"${value}"` : value;
+  }
+
+  function formatTag(entry: { [key: string]: string }) {
+    return entry.keyword.trim() + ":" + formatValue(entry.value);
+  }
+
   var newQuery = query.trim();
   if (
     current.find(
       (e) => e.keyword === newSelected.keyword && e.value === newSelected.value,
     ) === undefined
   ) {
-    newQuery =
-      newQuery + " " + newSelected.keyword.trim() + ":" + newSelected.value;
+    newQuery = newQuery + " " + formatTag(newSelected);
   } else {
     newQuery = newQuery
-      .replaceAll(newSelected.keyword + ":" + newSelected.value, "")
-      .replace(/  +/g, " ");
+      .replaceAll(" " + formatTag(newSelected), "")
+      .replaceAll(formatTag(newSelected), "");
   }
 
   await router
     .push({ name: "search", query: { q: newQuery.trim() } })
-    .catch(() => console.warn("Duplicated navigation 3:"));
+    .catch(() => console.warn("Duplicated navigation"));
 }
 </script>