Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert BQ-avro change #5595

Closed
wants to merge 2 commits into from
Closed

Revert BQ-avro change #5595

wants to merge 2 commits into from

Conversation

kellen
Copy link
Contributor

@kellen kellen commented Feb 4, 2025

No description provided.

@RustedBones
Copy link
Contributor

Causing some issue ?

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 60.86957% with 9 lines in your changes missing coverage. Please review.

Project coverage is 61.35%. Comparing base (57dbbad) to head (513a38c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...n/scala/com/spotify/scio/bigquery/BigQueryIO.scala 72.22% 5 Missing ⚠️
...la/com/spotify/scio/bigquery/client/TableOps.scala 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5595      +/-   ##
==========================================
+ Coverage   61.32%   61.35%   +0.02%     
==========================================
  Files         314      314              
  Lines       11236    11224      -12     
  Branches      778      806      +28     
==========================================
- Hits         6891     6886       -5     
+ Misses       4345     4338       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kellen
Copy link
Contributor Author

kellen commented Feb 4, 2025

@RustedBones Yeah; failing in streaming pipelines and some as-yet-untriaged schema compat. I may not actually merge this as we are blocking the rollout internally

@kellen
Copy link
Contributor Author

kellen commented Feb 6, 2025

Closing in favor of the less nuclear #5598

@kellen kellen closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants