Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper reference to sdk in WfsCamera.acquire_wavefront #1

Open
julesfowler opened this issue Jun 15, 2021 · 0 comments
Open

Improper reference to sdk in WfsCamera.acquire_wavefront #1

julesfowler opened this issue Jun 15, 2021 · 0 comments

Comments

@julesfowler
Copy link

Hello!

We're wanting to use your python library to work with some ThorLabs Wavefront Sensors. I think I may have found a bug? (My sincerest apologies if I just misunderstood the bit of code.)

In trying to recreate the snippet in wfs.py where you spin up the libraries and connect, I believe by time you get to the acquire_wavefront function there's a bug. The last line of this function (line 91 of wfs.py) calls sdk.calc_wavefront. While that works in the if __name__ == "__main__" snippet, I believe that's a coincidence because sdk has just been defined in the snippet above. I think it should be calling self._sdk.calc_wavefront, as the other references to the sdk are within that function.

If I'm correct, I'd be happy to open a PR with this change.

Thanks for writing a super slick library -- this has made our lives a lot easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant