Hotfix of critical screen navigation issue

spockele · Jun 10, 2024 · 2275bb5 · 2275bb5
1 parent 32c7ec2
commit 2275bb5
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 [//]: # (### Fixed)
 
+## [v1.1.1] - 10 June 2024
+
+### Fixed
+Hotfix for a critical navigation issue that makes v1.1.0 unusable.
+This issue was related to the incomplete removal of the unused pre-navigation function of the PalilaScreen class
+
+
 ## [v1.1.0] - 3 June 2024
 
 ### Added

diff --git a/CITATION.cff b/CITATION.cff
@@ -1,9 +1,8 @@
 cff-version: 1.2.0
-message: "If you use this software, please cite it as below."
 
 title: "Graphical User Interface for the Psychoacoustic Listening Laboratory (PALILA GUI)"
-version: v1.1.0
-date-released: 2024-06-03
+version: v1.1.1
+date-released: 2024-06-10
 
 authors:
 - family-names: "Pockelé"

diff --git a/GUI/screens.py b/GUI/screens.py
@@ -79,12 +79,7 @@ def on_release(self) -> None:
         """
         Click action button to do the navigation if the button is unlocked
         """
-        # Have the parent screen do its pre-navigation actions (which should return a boolean)
-        # The pre-navigation should do any messaging towards the user
-        ready = self.parent.pre_navigation()
-        # When the screen is ready, navigate
-        if ready:
-            self.parent.manager.navigate_next()
+        self.parent.manager.navigate_next()
 
     def unlock(self, *_) -> None:
         """
@@ -186,7 +181,7 @@ def __init__(self, pid_mode: str, welcome_text: str, *args, **kwargs) -> None:
 
         self.ids.welcome.text = welcome_text
 
-    def pre_navigation(self) -> None:
+    def on_pre_leave(self) -> None:
         """
         Function setting the PID before navigating
         """

diff --git a/README.md b/README.md
@@ -51,7 +51,7 @@ limitations under the License.
 ### Citation
 If you use this code for published research, please cite it as below:
 ```
-Pockelé, J.S. (2024). Graphical User Interface for the Psychoacoustic Listening Laboratory (PALILA GUI) (version v1.1.0). Zenodo. DOI: 10.5281/zenodo.11028965.
+Pockelé, J.S. (2024). Graphical User Interface for the Psychoacoustic Listening Laboratory (PALILA GUI) (version v1.1.1). Zenodo. DOI: 10.5281/zenodo.11028965.
 ```
 
 ---