Sonarcube issues fix (wip) #2683
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbylica-splunk
force-pushed
the
sonarcube_issues_fix
branch
from
5a6dc22 to
aabcf54
Compare
sbylica-splunk
force-pushed
the
sonarcube_issues_fix
branch
from
b80bb67 to
6972de8
Compare
sbylica-splunk
changed the title
|
change the title to comply with the SemVer style, for example |
ansible/Dockerfile
Outdated
| RUN apt-get install sshpass | ||
| RUN apt-get update -y \ | ||
| && apt-get --no-install-recommends install parallel -y build-essential \ | ||
| && apt-get --no-install-recommends install sshpass -y build-essential \ |
There was a problem hiding this comment.
can we do apt install --no-install-recommends -y parallel build-essential sshpass
There was a problem hiding this comment.
Ok, changed both of them
There was a problem hiding this comment.
can you also remove the duplicated build-essential installation? was it required by sonarcube to add this lib?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.