Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BA yamls #3029

Merged
merged 47 commits into from
Jul 10, 2024
Merged

Remove BA yamls #3029

merged 47 commits into from
Jul 10, 2024

Conversation

patel-bhavin
Copy link
Contributor

Removing BA yamls

@patel-bhavin patel-bhavin requested a review from P4T12ICK as a code owner July 9, 2024 00:35
@patel-bhavin patel-bhavin changed the base branch from develop to contentctl_unit_changes July 9, 2024 00:37
@patel-bhavin patel-bhavin changed the base branch from contentctl_unit_changes to develop July 9, 2024 23:42
@patel-bhavin patel-bhavin changed the base branch from develop to contentctl_unit_changes July 9, 2024 23:44
@patel-bhavin patel-bhavin changed the base branch from contentctl_unit_changes to develop July 10, 2024 17:18
@ljstella ljstella requested review from ljstella and removed request for P4T12ICK July 10, 2024 17:31
@ljstella
Copy link
Contributor

Think you should set build_ssa to false in contentctl.yml before this merges- somewhat concerning that with it set to true but none of the files or folders present that contentctl doesn't yell.

@patel-bhavin
Copy link
Contributor Author

Think you should set build_ssa to false in contentctl.yml before this merges- somewhat concerning that with it set to true but none of the files or folders present that contentctl doesn't yell.

Great point! I will push that change!

Copy link
Contributor

@ljstella ljstella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break a bunch of links that are already likely already broken- otherwise this should be fine once we know what we're doing with it all.

@patel-bhavin patel-bhavin merged commit 552d46e into develop Jul 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants