Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deterministic output for rba dict #362

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Conversation

pyth0n1c
Copy link
Contributor

@pyth0n1c pyth0n1c commented Feb 4, 2025

define serialization functions
for rba and risk bits in line with
normal pydantic workflow.

There is currently an issue where, because RBA objects now exist in a set,
the serialization order when writing to conf files can change. Because
of that, the contentctl inspect metadata validation flow can detect
non-meaningful changes in a conf file which, nevertheless, require
bumping version of a detection due to conf file changes.

for rba and risk bits in line with
normal pydantic workflow
@ljstella ljstella self-requested a review February 4, 2025 20:17
Copy link
Contributor

@ljstella ljstella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pyth0n1c pyth0n1c merged commit 30c7e80 into main Feb 4, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants