Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expense-list): Display the attachment count only when the expense includes attachments #267

Merged
merged 5 commits into from
Dec 7, 2024

Conversation

yuvarajsai
Copy link
Contributor

@yuvarajsai yuvarajsai commented Dec 2, 2024

We can have attachments for expenses, but in expenses list we do not show if a particular expense has an attachment or not. Relates to #238

Before:
image

After:

Expense has attachments:

image
image

Mobile:

image

No attachments:

image

@scastiel
Copy link
Member

scastiel commented Dec 7, 2024

This is great @yuvarajsai, thanks a lot!

I updated two things on your PR:

  1. I removed the label "attachment" as we don't have translations for all languages, and I think the icon makes it pretty explicit,
  2. I optimized the query to return only the document count instead of the whole document list.

@scastiel scastiel merged commit 72ad0a4 into spliit-app:main Dec 7, 2024
1 check passed
@yuvarajsai
Copy link
Contributor Author

This is my first open source PR and glad that you appreciate it @scastiel 🙌
The both changes you made make perfect sense.

Please feel free to assign any issues in this or spliit-mobile repo. I really appreciate the idea of "spliit" being an open-source project. Thank you for this initiative and your efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants