New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding environment variables, removing unused bootloaders from Kernel #141

Merged

butschster merged 1 commit into installer from feature/env

Dec 12, 2023

Member

msmakouz commented Dec 12, 2023

What was changed

The unnecessary bootloaders have been removed from the Kernel.

Roadrunner bootloaders are added by the generator here:
https://github.com/spiral/app/blob/installer/installer/Module/RoadRunnerBridge/Common/Generator/Bootloaders.php
If the Roadrunner installation is selected in the installer.
YiiErrorHandlerBootloader is also added here:
https://github.com/spiral/app/blob/installer/installer/Module/ErrorHandler/Yii/Generator/Bootloaders.php
If the spiral-packages/yii-error-handler-bridge package is installed.

The unnecessary deprecated constants SYSTEM, LOAD, APP have been removed.
Environment variables have been added to the database config and phpunit.xml config for convenience of use.


          Add environment variables, remove unused bootloaders from kernel

a45103e

msmakouz added the enhancement label

msmakouz requested a review from butschster

December 12, 2023 13:07

msmakouz self-assigned this

butschster approved these changes

View reviewed changes

butschster merged commit e9ed32d into installer

6 checks passed

butschster deleted the feature/env branch

December 12, 2023 16:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels