Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update installation.md with uv dependency #1358

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Update installation.md with uv dependency #1358

merged 1 commit into from
Dec 26, 2024

Conversation

Jojo144
Copy link
Contributor

@Jojo144 Jojo144 commented Dec 25, 2024

Probably not perfect but better than nothing :-)

@Jojo144 Jojo144 mentioned this pull request Dec 25, 2024
Closed
@almet
Copy link
Member

almet commented Dec 25, 2024

This documentation is about the dependencies of IHM as a project. uv is only required if you want to install and work on ihatemoney, so I believe this should belong to https://github.com/spiral-project/ihatemoney/blob/master/docs/contributing.md#set-up-a-dev-environment instead, adding a requirement section.

@Jojo144
Copy link
Contributor Author

Jojo144 commented Dec 25, 2024

Updated!
I had hesitated :-)

almet
almet approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@almet almet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect, thanks a lot @Jojo144

@almet almet merged commit dcb61b6 into spiral-project:master Dec 26, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almet almet almet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jojo144 @almet