-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Remember the last selected payer for each project #1224
[Fix] Remember the last selected payer for each project #1224
Conversation
aaf65c8
to
b36c44a
Compare
Hey, thanks for the changes. Could you make some edits so that it's not lost for all users when we release the new version? You could do that by checking if Also, could you add some tests about this, to ensure it's working the way it's intended? Thanks :-) |
@almet Are you sure of that? 99.9 % won't remark that the default user is lost during the update and it will produce dead code... I have a look at the tests. |
We can mark the code for deletion later with a comment, it's not an issue. Thanks :-) |
b36c44a
to
bc7bc96
Compare
I also don't think we need compatibility on this one, especially because it was already lost when switching project. But now it's done... @Jojo144 you also need to rebase that one, sorry. Can you also adapt your test to use plain asserts? |
In the meantime #1213 has been merged. Can you use pytest assertions in unit tests? |
e0ef83d
to
8608ffc
Compare
Done. Thanks for your comment. |
Thanks! |
Previously the last selected payer was lost when switching of project.
The structure of the variable
last_selected_payer
is changed (now it's a dictionary) then it has been renamed tolast_selected_payer_per_project
to avoid session bugs.