Default owers when adding a bill #1222
Conversation
ihatemoney/web.py
Outdated
| bill_form.payer.data = session["last_selected_payer"] | ||
| if g.project.id in session["last_selected_payer"]: | ||
| bill_form.payer.data = session["last_selected_payer"][g.project.id] |
There was a problem hiding this comment.
Question for Flask experts:
When does the session expires? I changed the representation of session["last_selected_payer"], does the session automatically expires during an update of IHM?
There was a problem hiding this comment.
No, the session is kept even when you update IHM, so you always need to account for the old format and convert it. This has been a frequent source of heisenbugs in the past.
In general, can you separate the two changes into separate commits/PR? One which adds the new "payed_for", and one which fixes the behaviour of payer.
There was a problem hiding this comment.
In general, can you separate the two changes into separate commits/PR?
I'll do that.
There was a problem hiding this comment.
I updated the PR. The bug fix is now in #1224 and the new feature in this PR.
|
I like the idea, and the "simple" approach with the session looks good to me. As said above, please separate the new feature and the fix. You can look at adding a test (including for the fix, to avoid a regression). You can find a similar test here I believe: test_session_projects_migration_to_list |
zorun
changed the title
Jojo144
force-pushed
the
default_payed_for
branch
from
59a9f66 to
5ec056d
Compare
|
Woah, all tests fail with this error: This looks totally unrelated to your change... Can you try to rebase? |
Jojo144
force-pushed
the
default_payed_for
branch
2 times, most recently
from
fb6f1fe to
82d9ecc
Compare
|
Sorry, you need to rebase because of the tests re-organisation + the flask-wtf fix |
Jojo144
force-pushed
the
default_payed_for
branch
from
82d9ecc to
89f9e6f
Compare
|
Can you fix the conflict? |
Jojo144
force-pushed
the
default_payed_for
branch
from
89f9e6f to
ac3a4e5
Compare
|
Perfect, thanks. |
* Remember last owers for next new bill * Add a test for last_selected_payed_for
English
In short. Would you find nice to:
?
(This PR implements 1.)
Français
J'utilise régulièrement IHM dans un projet où je sélectionne toujours les mêmes "Pour qui ?" quand je saisi une facture. C'est un peu long de désélectionner à chaque fois.
Est-ce que vous seriez intéressés par une des propositions suivantes :
?
Ma préférence va à 1 (interface plus légère). Et vous ?
(Cette PR implémente 1.)