Solved the issue deactivated user's bill cannot be edited #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almet
force-pushed
the
yiqun-issue2
branch
6 times, most recently
from
774ccf1 to
a4899db
Compare
|
Superseded by #1104, thanks for the contribution and sorry for letting this bitrot for a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved #1080 that deactivated user's bill can still be edited.
Before, this system allows to deactivate user with non-zero bill value. However, the bill can still be edited by other active member.
After, the deactivated user's bill cannot be edited with a prompt noticing the users.
Test has been made with this fix.