Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jenkins): Use Long values rather than Ints for buildNumbers and Queue numbers #1304

Closed
wants to merge 3 commits into from

Conversation

michaelepperson
Copy link
Contributor

This PR is to resolve #7002.

Cloudbees has started using Long for HA enabled Queues. To resolve this, Starting from the getQueue code, I have change the expected type from Int to Long. I followed the trail through until all changes needed were made.

Copy link
Member

@jasonmcintosh jasonmcintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should cover all the areas for coms. I don't know that we needed travis, but since this is a generic API change, this should help across the board to support longer build numbers.

@jasonmcintosh
Copy link
Member

ALSO: There will be needed some Orca work to handle longer times as well. E.g.:
https://github.com/spinnaker/orca/blob/33097a3ae6de11926cdd0187f20d81cd2251e368/orca-igor/src/main/java/com/netflix/spinnaker/orca/igor/IgorService.java#L42

Separate PR for that should be incoming.

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • 42cd6bf: #7002: Converting build Id's from Int to Long to support Cloudbees.

  • 194ba20: #7002: Updated Tests to include Long ID for build number, and updated the BuildController to use a long instead of Int

  • 00f1344: #7002: Added Queued job Int to Long conversion and made all build variables Longs for full test

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@michaelepperson michaelepperson changed the title #7002: Converting build Id's from Int to Long to support Cloudbees. fix(jenkins): Use Long values rather than Ints for buildNumbers and Queue numbers Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Igor - jenkins connectivity issue after upgrade to 1.35.4
3 participants