Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More SQLAlchemy compatibility #488

Merged
merged 1 commit into from
Feb 10, 2025
Merged

More SQLAlchemy compatibility #488

merged 1 commit into from
Feb 10, 2025

Conversation

soininen
Copy link
Collaborator

@soininen soininen commented Feb 10, 2025

With this, spinedb_api should be ready for SQLAlchemy 2.0.

Resolves #477

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

This should be the last step on our way to SQLAlchemy 2.0 compatibility.

Re #477
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.92%. Comparing base (308c085) to head (934bb57).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...edb_api/spine_io/importers/sqlalchemy_connector.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #488   +/-   ##
=======================================
  Coverage   81.92%   81.92%           
=======================================
  Files          78       78           
  Lines       10306    10306           
  Branches     1550     1550           
=======================================
  Hits         8443     8443           
  Misses       1493     1493           
  Partials      370      370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen merged commit 28f2c6b into master Feb 10, 2025
14 of 15 checks passed
@soininen soininen deleted the 477_set_session_future branch February 10, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for SQLAlchemy 2.0
1 participant