Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQLAlchemy warnings #486

Merged
merged 4 commits into from
Feb 7, 2025
Merged

Fix SQLAlchemy warnings #486

merged 4 commits into from
Feb 7, 2025

Conversation

soininen
Copy link
Collaborator

@soininen soininen commented Feb 7, 2025

This PR fixes SQLAlchemy warnings including all deprecation warnings from unit tests. No functional changes intended. This should bring us a step closer to SQLAlchemy 2.0.

Re #477

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

@soininen soininen force-pushed the 477_fix_sqlalchemy_warnings branch from d89ef73 to f3a182f Compare February 7, 2025 11:52
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 69.76744% with 13 lines in your changes missing coverage. Please review.

Project coverage is 81.55%. Comparing base (cefebcb) to head (f3a182f).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
spinedb_api/db_mapping.py 53.84% 9 Missing and 3 partials ⚠️
spinedb_api/helpers.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #486   +/-   ##
=======================================
  Coverage   81.55%   81.55%           
=======================================
  Files          78       78           
  Lines       10308    10309    +1     
  Branches     1551     1551           
=======================================
+ Hits         8407     8408    +1     
  Misses       1538     1538           
  Partials      363      363           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen merged commit 21ca5f0 into master Feb 7, 2025
14 of 15 checks passed
@soininen soininen deleted the 477_fix_sqlalchemy_warnings branch February 7, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant