Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writable parsed_value #480

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Writable parsed_value #480

merged 3 commits into from
Jan 30, 2025

Conversation

soininen
Copy link
Collaborator

@soininen soininen commented Jan 30, 2025

Parameter definition, parameter value and list value items can now be added and updated using the parsed_value field directly. This removes the need to call to_database() each time before calling these operations.

Implements #479

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

It is now possible to replace "value", "default_value", "type"
and "default_type" by "parsed_value" when adding parameter values,
definitions or list values.

Re #479
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 95.74468% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.10%. Comparing base (9570601) to head (56e3f6a).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
spinedb_api/mapped_items.py 95.23% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
+ Coverage   81.05%   81.10%   +0.05%     
==========================================
  Files          76       76              
  Lines        9890     9882       -8     
  Branches     1473     1477       +4     
==========================================
- Hits         8016     8015       -1     
+ Misses       1529     1520       -9     
- Partials      345      347       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen merged commit af82848 into master Jan 30, 2025
15 checks passed
@soininen soininen deleted the 479_writable_parsed_value branch January 30, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant