Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entity groups to alternative and scenario filters #470

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

soininen
Copy link
Collaborator

@soininen soininen commented Jan 7, 2025

This PR implements entity group filtering in scenario and alternative filters.

Resolves spine-tools/Spine-Toolbox#3004

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.42%. Comparing base (1245aca) to head (8ef4c8f).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
+ Coverage   80.38%   80.42%   +0.03%     
==========================================
  Files          77       77              
  Lines       10030    10049      +19     
  Branches     1477     1477              
==========================================
+ Hits         8063     8082      +19     
  Misses       1625     1625              
  Partials      342      342              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen merged commit b55eb54 into master Jan 7, 2025
13 checks passed
@soininen soininen deleted the toolbox_3004_fix_filtered_entity_groups branch January 7, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugs on filtering with entity alternatives
1 participant