Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise NothingToCommit when there is nothing to commit #455

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

soininen
Copy link
Collaborator

@soininen soininen commented Oct 9, 2024

It is now possible to ignore the specific condition of nothing-to-commit:

with suppress(NothingToCommit):
    db_map.commit_session("May or may contain changes.")

No associated issue.

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

There should be a way to ignore the specific condition of
nothing-to-commit when calling commit_session()
@soininen soininen force-pushed the nothing_to_commit_exception branch from c7c856e to 7ce0427 Compare October 9, 2024 13:36
@soininen soininen changed the title Rais NothingToCommit when there is nothing to commit Raise NothingToCommit when there is nothing to commit Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.13%. Comparing base (2bbfd92) to head (7ce0427).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #455      +/-   ##
==========================================
- Coverage   79.13%   79.13%   -0.01%     
==========================================
  Files          77       77              
  Lines       10099    10102       +3     
  Branches     2142     1806     -336     
==========================================
+ Hits         7992     7994       +2     
- Misses       1756     1760       +4     
+ Partials      351      348       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen merged commit 13e4a04 into master Oct 9, 2024
14 checks passed
@soininen soininen deleted the nothing_to_commit_exception branch October 9, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant