Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding parameter definitions by entity class id #454

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

soininen
Copy link
Collaborator

@soininen soininen commented Oct 8, 2024

This PR fixes a Traceback that would occur when parameter definitions were added using entity class id instead of name.

Fixes irena-flextool/flextool#228

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.13%. Comparing base (bd929d0) to head (2665daa).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #454   +/-   ##
=======================================
  Coverage   79.13%   79.13%           
=======================================
  Files          77       77           
  Lines       10096    10099    +3     
  Branches     2142     2142           
=======================================
+ Hits         7989     7992    +3     
  Misses       1756     1756           
  Partials      351      351           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen merged commit 2bbfd92 into master Oct 8, 2024
14 checks passed
@soininen soininen deleted the fix_add_parameter_definition branch October 8, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyerror: 'entity_class_name`. Merger run takes forever without stopping.
1 participant