Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fetch bookkeeping #450

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Improve fetch bookkeeping #450

merged 1 commit into from
Sep 18, 2024

Conversation

soininen
Copy link
Collaborator

@soininen soininen commented Sep 18, 2024

fetch_all() was calling do_fetch_more() directly, but it makes more sense to call do_fetch_all() instead to keep record of what has been fetched.

No associated issue

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black & isort
  • Unit tests pass

fetch_all() was calling do_fetch_more() directly, but it makes more
sense to call do_fetch_all() to keep record of what has been fetched.
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.10%. Comparing base (7e55a21) to head (a172985).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
- Coverage   79.10%   79.10%   -0.01%     
==========================================
  Files          77       77              
  Lines       10076    10078       +2     
  Branches     2140     2141       +1     
==========================================
+ Hits         7971     7972       +1     
  Misses       1755     1755              
- Partials      350      351       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen merged commit d91a2ed into master Sep 18, 2024
14 checks passed
@soininen soininen deleted the fetch_all_via_do_fetch_all branch September 18, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant