Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes in PR 333 #343

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Revert changes in PR 333 #343

merged 1 commit into from
Jan 31, 2024

Conversation

soininen
Copy link
Collaborator

This reverts PR #333 as discussed there. A new PR will be opened for the changes to sort out issues.

Re spine-tools/Spine-Toolbox#2431

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes in Toolbox repo have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black
  • Unit tests pass

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a97c794) 77.12% compared to head (58f12b3) 77.12%.
Report is 13 commits behind head on 0.8-dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           0.8-dev     #343   +/-   ##
========================================
  Coverage    77.12%   77.12%           
========================================
  Files           75       75           
  Lines         9241     9241           
  Branches      1950     1950           
========================================
  Hits          7127     7127           
  Misses        1781     1781           
  Partials       333      333           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen merged commit 2da3e72 into 0.8-dev Jan 31, 2024
8 checks passed
@soininen soininen deleted the toolbox_2431_revert_PR_333 branch January 31, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants