Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active_by_default flag to entity_class table #336

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

soininen
Copy link
Collaborator

@soininen soininen commented Jan 15, 2024

Added active_by_default flag to entity_class table which specifies the default value for entity alternatives of the entities of the class. By default, zero-dimensional entities have the flag set to False while for multidimensional entities, it is set to True.

Since this change alters the entity_class table, we now have a new migration script as well.

Queries, filters etc. were updated, too.

Implements #316

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes in Toolbox repo have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black
  • Unit tests pass

Added active_by_default flag to entity_class table which specifies the
default value for entity alternatives of the entities of the class.
By default, zero-dimensional entities have the flag unset while
it is set for multidimensional entities.

Since this change alters the entity_class table, we now have a new
migration script as well.

Queries, filters etc. were updated, too.

Re #316
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (44b6883) 77.07% compared to head (ab1b8e2) 77.14%.
Report is 1 commits behind head on 0.8-dev.

Files Patch % Lines
spinedb_api/mapped_items.py 66.66% 1 Missing and 1 partial ⚠️
...eff478bcb_add_active_by_default_to_entity_class.py 95.45% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           0.8-dev     #336      +/-   ##
===========================================
+ Coverage    77.07%   77.14%   +0.06%     
===========================================
  Files           74       75       +1     
  Lines         9205     9239      +34     
  Branches      1944     1949       +5     
===========================================
+ Hits          7095     7127      +32     
- Misses        1778     1780       +2     
  Partials       332      332              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soininen soininen merged commit 43c1bb6 into 0.8-dev Jan 17, 2024
8 checks passed
@soininen soininen deleted the 316_entity_alternative_default_activity branch January 17, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants