spire-server: improve entry lookup for NewJWTSvid and BatchX509SVID requests #5819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorindumitru
force-pushed
the
lookup-authorized-entries
branch
5 times, most recently
from
a55d656 to
d8cc2ac
Compare
sorindumitru
force-pushed
the
lookup-authorized-entries
branch
from
d8cc2ac to
5736cb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently opening this a draft, to continue the discussion. Still requires some tests. Overall this seems to improve CPU usage substantially while not affecting other metrics, memory, network, etc.:
Pull Request check list
Affected functionality
NewJWTSVID and BatchX509SVID server APIs.
Description of change
Instead of fetching all authorized entries for a new SVID signing requests, only fetch the ones required. In the case of signign JWT-SVIDs, it's only one so there's a big improvement. In the case of X509-SVID, this is usually done in a batch so improvements will depend on batch size and the number of entries the agent is authorized for.
Which issue this PR fixes
#5801