Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker documentation was incorrectly referencing an invalid tag format #5809

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Docker documentation was incorrectly referencing an invalid tag format #5809

merged 3 commits into from
Jan 24, 2025

Conversation

calebjonasson
Copy link
Contributor

Pull Request check list

  • Commit conforms to CONTRIBUTING.md?
  • Proper tests/regressions included?
  • Documentation updated?

Affected functionality

  • N/A - Docker documentation incorrectly referenced an invalid tag format that does not exist in ghcr.

Description of change

  • documentation changes:
    • Removing a 'v' at the beginning of a docker container label.
    • Updating minor version for the example.

Which issue this PR fixes

  • N/A

@calebjonasson
Docker documentation was incorrectly referencing an invalid tag format
eb23f00 
Signed-off-by: calebjonasson <caleb.jonasson@gmail.com>
MarcosDY
MarcosDY approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@MarcosDY MarcosDY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@MarcosDY MarcosDY merged commit 605a4ca into spiffe:main Jan 24, 2025
35 checks passed
@MarcosDY MarcosDY added this to the 1.11.2 milestone Jan 24, 2025
@calebjonasson calebjonasson deleted the doc-docker-version-fix branch January 25, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosDY MarcosDY MarcosDY approved these changes

@evan2645 evan2645 Awaiting requested review from evan2645 evan2645 is a code owner

@amartinezfayo amartinezfayo Awaiting requested review from amartinezfayo amartinezfayo is a code owner

@azdagron azdagron Awaiting requested review from azdagron

@rturner3 rturner3 Awaiting requested review from rturner3 rturner3 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11.2
Development

Successfully merging this pull request may close these issues.
2 participants
@calebjonasson @MarcosDY