SPIFFE_ENDPOINT_SOCKET env support for spire-agent #5776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
kfox1111
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
MarcosDY
reviewed
Jan 21, 2025
Comment on lines
+16
to
+17
| // DefaultSocketPath is the SPIRE agent's default socket path | ||
| var DefaultSocketPath string |
There was a problem hiding this comment.
This will be used for API calls and health checks, except for the run command, where we will continue using DefaultRunSocketPath.
Is it expected to affect health checks?
If not, should we update the code to modify the default within AddOSFlags instead?
There was a problem hiding this comment.
We chatted about this. I believe the current plan is to do everything but run in one pr, and run in a future pr.
|
SPIFFE_ENDPOINT_SOCKET needs to support unix:// on the front according to: https://github.com/spiffe/spiffe/blob/main/standards/SPIFFE_Workload_Endpoint.md#4-locating-the-endpoint But this patch doesn't work with that currently. |
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
Signed-off-by: kfox1111 <Kevin.Fox@pnnl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables specifying SPIFFE_ENDPOINT_SOCKET to the non run subcommands to the spire-agent
partially-fixes: #5770