cli command to validate configuration using plugin validation routines. #5626
Conversation
Signed-off-by: Edwin Buck <edwbuck@gmail.com>
Signed-off-by: Edwin Buck <edwbuck@gmail.com>
Signed-off-by: Edwin Buck <edwbuck@gmail.com>
edwbuck
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
…tprint. This is to save work that is ongoing. Signed-off-by: Edwin Buck <edwbuck@gmail.com>
Signed-off-by: Edwin Buck <edwbuck@gmail.com>
Signed-off-by: Edwin Buck <edwbuck@gmail.com>
Signed-off-by: Edwin Buck <edwbuck@gmail.com>
Now the validate handling is integrated into the server config and all sub-config structs, and the main server Run() func is responsible for both launching the server and validating, based on the flag, per request by Andrew. Signed-off-by: Edwin Buck <edwbuck@gmail.com>
Andrew's plan to make the validation use the config objects to hold flags means that we can't pass by value, as the caller will lack the return path of getting the validation notes. Signed-off-by: Edwin Buck <edwbuck@gmail.com>
Signed-off-by: Edwin Buck <edwbuck@gmail.com>
|
@edwbuck we are reviewing 1.11.1 release and see that we will need to call a commit for that around thanksgiving time. This PR is tagged for that release, however it is still in draft and seems it needs more work. We will also need time to review once it comes out of draft. When do you think that will happen? |
Hi Evan. I'll put some more effort into it today. I was going to revisit it this weekend, but I have a few hours to start early. I am still planning to be ready for the Dec 5 deadline (with extra time for the review process) but if it's not in good shape by the end of this weekend, I'll express it in the next contributor's call. |
Refactoring and restructured SQL "outside of the datasource" configuraiton issues, now centralized into validateSQLConfig, embedded in loadSQLConfig. Signed-off-by: Edwin Buck <edwbuck@gmail.com>
Signed-off-by: Edwin Buck <edwbuck@gmail.com>
Signed-off-by: Edwin Buck <edwbuck@gmail.com>
Signed-off-by: Edwin Buck <edwbuck@gmail.com>
|
A forgotten code signoff in the middle of the MR makes this branch difficult, if not impossible to move forward (it's not a matter of just rewriting my history, but also the history of two main branch merge requests). Please close this and proceed with its replacement #5665 Also, please target #5665 for the 1.11.1 release to preserve the release planning. |
|
Closing in favor of #5665. |
Closes #5268