Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude dependabot author from new DCO check #5026

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

rturner3
Copy link
Collaborator

Tested locally:

> git show HEAD
commit cf1f67f7e922d841eb353c39240078f3d43c795f (HEAD -> test-dependabot-dco)
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Mar 28 17:00:52 2024 -0700

    Test commit resembling dependabot for DCO check

    Signed-off-by: dependabot[bot] <support@github.com>

diff --git a/README.md b/README.md
index c7022cb7..9f3a2d40 100644
--- a/README.md
+++ b/README.md
@@ -17,7 +17,7 @@ SPIRE (the [SPIFFE](https://github.com/spiffe/spiffe) Runtime Environment) is a

 SPIRE is a [graduated](https://www.cncf.io/projects/spire/) project of the [Cloud Native Computing Foundation](https://cncf.io/) (CNCF). If you are an organization that wants to help shape the evolution of technologies that are container-packaged, dynamically-scheduled and microservices-oriented, consider joining the CNCF.

-## Get SPIRE
+## Get SPIRE - foo

 - Pre-built releases of SPIRE can be found at [https://github.com/spiffe/spire/releases](https://github.com/spiffe/spire/releases). These releases contain both SPIRE Server and SPIRE Agent binaries.
 - Container images are published for [spire-server](https://ghcr.io/spiffe/spire-server), [spire-agent](https://ghcr.io/spiffe/spire-agent), and [oidc-discovery-provider](https://ghcr.io/spiffe/oidc-discovery-provider).

> python3 dco_check.py -b main
Detected: git (default)

Checking commits: 0727fa64f7af0330c3b4e1404d2e240bdd44cfe5..cf1f67f7e922d841eb353c39240078f3d43c795f

Missing sign-off(s):

	cf1f67f7e922d841eb353c39240078f3d43c795f
		sign-off not found for commit author: dependabot[bot] 49699333+dependabot[bot]@users.noreply.github.com; found: ['dependabot[bot] <support@github.com>']

> python3 dco_check.py -b main --exclude-pattern 'dependabot\[bot\]@users\.noreply\.github\.com'
Detected: git (default)

Checking commits: 0727fa64f7af0330c3b4e1404d2e240bdd44cfe5..cf1f67f7e922d841eb353c39240078f3d43c795f

All good!

Signed-off-by: Ryan Turner <turner@uber.com>
@MarcosDY MarcosDY merged commit cafce4d into spiffe:main Mar 29, 2024
33 checks passed
rushi47 pushed a commit to rushi47/spire that referenced this pull request Apr 11, 2024
Signed-off-by: Ryan Turner <turner@uber.com>
@amartinezfayo amartinezfayo added this to the 1.9.6 milestone May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants