feat(docker): Add flexible multi-stage Dockerfile for application builds #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Supports building different applications with configurable architecture - Uses multi-stage builds for optimized image creation - Includes distroless base and static image targets - Supports conditional CGO and crypto configuration
v0lkan
reviewed
Feb 20, 2025
|
|
||
| FROM gcr.io/distroless/static AS distroless-static | ||
| COPY --from=builder /workspace/$APP /binary | ||
| ENTRYPOINT ["/binary"] |
There was a problem hiding this comment.
Since we have CGO_ENABLED (at least for Nexus), we will need a mac (virtual) machine to create all cross-platform builds... (otherwise, for example a debian builder will not find relevant tool-chain to link mac/darwin bindings to build the binaries for the target os)
which is fine with me, I already have one mac build vm.
it just means, we'll need 9 (3 mac arm, 3 linux arm, 3 linux x86) container registries, instead of 3 -- which is fine with me, since there'll be some "form" of release automation anyway.
There was a problem hiding this comment.
Upon further discussion on other channels, there may be hope :)
I'll test things out and get back here :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerfile
Helm charts are to come in another PR
fixes #16