-
-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change folder location for Backup
and Extracted
#3282
Open
UnaTried
wants to merge
8
commits into
spicetify:main
Choose a base branch
from
UnaTried:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnaTried
changed the title
Changing Folder location for folder
refactor: Changing Folder location for folder Jan 26, 2025
Backup
and Extracted
Backup
and Extracted
UnaTried
changed the title
refactor: Changing Folder location for folder
refactor: Changing Folder location for folder Backup and Extracted
Jan 26, 2025
Backup
and Extracted
UnaTried
changed the title
refactor: Changing Folder location for folder Backup and Extracted
refactor(#3201): Changing Folder location for folder Backup and Extracted
Jan 26, 2025
UnaTried
changed the title
refactor(#3201): Changing Folder location for folder Backup and Extracted
refactor(#3201): changing folder location for folder Backup and Extracted
Jan 26, 2025
UnaTried
changed the title
refactor(#3201): changing folder location for folder Backup and Extracted
refactor(#3201): changing folder location for folder Jan 26, 2025
Backup
and Extracted
rxri
changed the title
refactor(#3201): changing folder location for folder
refactor: change folder location for Jan 31, 2025
Backup
and Extracted
Backup
and Extracted
rxri
requested changes
Feb 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't return anything when env variable is undefined & os isn't linux tho
As I said, I do not use go, I just tried to fix that issue mixing GetUserFolder and GetSpicetifyFolder to make GetStateFolder |
Then revert your last commit you made? |
Ok, I have reverted my commit @rxri |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was requested on issue #3201, I don't know how to test this, so I don't know if it will work. It should in theory though!
P.S: I am not a go-er I just made those changes, did
go build
and there was no ouput, so I assumed it worked, since it was throwing error whenever there was one.Linux only version