fix: add error handling to keyboard shortcuts for song navigation #3275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description This pull request adds error handling to the keyboard shortcuts for song navigation in the `keyboardShortcut.js` file. The changes ensure that any errors encountered while invoking `Spicetify.Player.next()` and `Spicetify.Player.previous()` are logged to the console for easier debugging. ### Changes - Added `try-catch` blocks around the callback functions for the `ctrl+right` and `ctrl+left` keybindings. - Logged errors using `console.error` if an exception occurs. ### Reason for Changes - To enhance the robustness of the keyboard shortcuts and provide better error logging for debugging purposes.
|
Did you even test what AI changed? because I guess you didn't. There's no need for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds error handling to the keyboard shortcuts for song navigation in the
keyboardShortcut.jsfile. The changes ensure that any errors encountered while invokingSpicetify.Player.next()andSpicetify.Player.previous()are logged to the console for easier debugging.Changes
try-catchblocks around the callback functions for thectrl+rightandctrl+leftkeybindings.console.errorif an exception occurs.Reason for Changes