Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preprocess): nuke ui logging #2667

Merged
merged 4 commits into from
Nov 24, 2023
Merged

feat(preprocess): nuke ui logging #2667

merged 4 commits into from
Nov 24, 2023

Conversation

SunsetTechuila
Copy link
Contributor

@SunsetTechuila SunsetTechuila commented Nov 18, 2023

the methodToDisable\{.+?\}nextMethodName part is not very reliable and can potentially break things in the future, so improve it if know how. Or close the pull request if you don't know and are afraid of breakages, but I spent several hours on it

@SunsetTechuila
Copy link
Contributor Author

tested with these spotify versions
image

@SunsetTechuila
Copy link
Contributor Author

SunsetTechuila commented Nov 18, 2023

the reason I even try to replace all method contents is that return doesn't somehow stop execution
image

@Delusoire
Copy link
Contributor

Delusoire commented Nov 18, 2023

It seems like all these methods use eventSender.send wouldn't it be better to just replace this one function with a noop?
Or even make validateEventData return something non null.

@SunsetTechuila
Copy link
Contributor Author

It seems like all these methods use eventSender.send wouldn't it be better to just replace this one function with a noop?

i'm already replacing it, but not all logging methods use eventSender.send, only the ones in vendor~xpui.js

Or even make validateEventData return something non null.

makes the console filled with endless errors and doesn't prevent saving logging data into localStorage

@afonsojramos
Copy link
Member

Nice! Thanks for the PR!

@afonsojramos afonsojramos merged commit a675c71 into spicetify:master Nov 24, 2023
5 checks passed
@SunsetTechuila SunsetTechuila deleted the logging branch November 24, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants